Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve get terminal window size in the docker container #15 #18

Merged
merged 2 commits into from Apr 29, 2019
Merged

Improve get terminal window size in the docker container #15 #18

merged 2 commits into from Apr 29, 2019

Conversation

skanehira
Copy link

relate #15

golangcibot
golangcibot reviewed Apr 28, 2019
View reviewed changes
gui.go Show resolved Hide resolved
@skanehira skanehira requested a review from glvr182 April 28, 2019 12:32
glvr182
glvr182 reviewed Apr 28, 2019
View reviewed changes
Copy link
Member

@glvr182 glvr182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some things I was curious about, overall looks good! Will approve after the questions are answered.

gui.go Show resolved Hide resolved
gui.go Show resolved Hide resolved
gui.go Show resolved Hide resolved
gui.go Show resolved Hide resolved
@glvr182
Copy link
Member

glvr182 commented Apr 29, 2019

Looks good! Can you rebase on the master branch?

@skanehira
Improve get terminal window size in the docker container #15
8668cab
@skanehira
fixed some
5b7b2af 
- Add documents for new function
- Only inside the container to use original get terminal window function
@skanehira
Copy link
Author

@glvr182 I rebased :)

@glvr182
Copy link
Member

glvr182 commented Apr 29, 2019

@skanehira Then i will merge this

@glvr182 glvr182 merged commit 4d77d32 into master Apr 29, 2019
@glvr182 glvr182 deleted the improveGetTermWindowSize branch April 29, 2019 16:56
@skanehira skanehira mentioned this pull request Apr 29, 2019
Closed
@mjarkk mjarkk mentioned this pull request Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjarkk mjarkk mjarkk approved these changes

@golangcibot golangcibot golangcibot left review comments

@glvr182 glvr182 glvr182 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skanehira @glvr182 @mjarkk @golangcibot